-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Circular structure in calendar object #5649
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## Migrate/to-nextcloud-vue-8 #5649 +/- ##
================================================================
+ Coverage 24.45% 24.52% +0.06%
Complexity 418 418
================================================================
Files 243 243
Lines 10831 10788 -43
Branches 1776 1755 -21
================================================================
- Hits 2649 2646 -3
+ Misses 8182 8142 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
291fbc1
to
82ac0e4
Compare
Eslint unrelated to this Pr |
Signed-off-by: hamza mahjoubi <[email protected]>
82ac0e4
to
1a95c37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Dav Object contains circular reference which breaks NcSelect

part of #5648