Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Circular structure in calendar object #5649

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Dec 29, 2023

Dav Object contains circular reference which breaks NcSelect
image
part of #5648

@hamza221 hamza221 added the 3. to review Waiting for reviews label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (23e3320) 24.45% compared to head (1a95c37) 24.52%.

Files Patch % Lines
src/components/Shared/CalendarPicker.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##             Migrate/to-nextcloud-vue-8    #5649      +/-   ##
================================================================
+ Coverage                         24.45%   24.52%   +0.06%     
  Complexity                          418      418              
================================================================
  Files                               243      243              
  Lines                             10831    10788      -43     
  Branches                           1776     1755      -21     
================================================================
- Hits                               2649     2646       -3     
+ Misses                             8182     8142      -40     
Flag Coverage Δ
javascript 15.57% <0.00%> (+0.06%) ⬆️
php 61.60% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221 hamza221 mentioned this pull request Dec 29, 2023
3 tasks
@hamza221 hamza221 force-pushed the fix/circularStructure branch from 291fbc1 to 82ac0e4 Compare December 29, 2023 14:24
@hamza221
Copy link
Contributor Author

Eslint unrelated to this Pr

@hamza221 hamza221 force-pushed the fix/circularStructure branch from 82ac0e4 to 1a95c37 Compare December 29, 2023 14:52
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@GVodyanov GVodyanov merged commit ad94eef into Migrate/to-nextcloud-vue-8 Jan 8, 2024
35 of 37 checks passed
@GVodyanov GVodyanov deleted the fix/circularStructure branch January 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants